-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ffi): Add initial implementation of IrErrorCode
(using the ErrorCode
template) which will replace the IRErrorCode
enum.
#623
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
17aed97
Add starter code for IrErrorCode
LinZhihao-723 3ba36ef
Fix the doc string
LinZhihao-723 3cbf8a9
Make error messages more descriptive
LinZhihao-723 f155aa1
Fix
LinZhihao-723 9a610c7
Update components/core/src/clp/ffi/ir_stream/IrErrorCode.cpp
LinZhihao-723 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
#include "IrErrorCode.hpp" | ||
|
||
#include <string> | ||
|
||
using IrErrorCategory = clp::error_handling::ErrorCategory<clp::ffi::ir_stream::IrErrorCodeEnum>; | ||
using clp::ffi::ir_stream::IrErrorCodeEnum; | ||
|
||
template <> | ||
auto IrErrorCategory::name() const noexcept -> char const* { | ||
return "clp::ffi::ir_stream::IrErrorCode"; | ||
} | ||
|
||
template <> | ||
auto IrErrorCategory::message(IrErrorCodeEnum error_enum) const -> std::string { | ||
switch (error_enum) { | ||
case IrErrorCodeEnum::DecodingMethodFailure: | ||
return "Decoding method failure."; | ||
case IrErrorCodeEnum::EndOfStream: | ||
return "End-of-stream has been reached."; | ||
case IrErrorCodeEnum::IncompleteStream: | ||
return "Incomplete IR stream."; | ||
default: | ||
return "Unknown error code enum."; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#ifndef CLP_IRERRORCODE_HPP | ||
#define CLP_IRERRORCODE_HPP | ||
|
||
#include <cstdint> | ||
|
||
#include "../../error_handling/ErrorCode.hpp" | ||
|
||
namespace clp::ffi::ir_stream { | ||
/** | ||
* This enum class represents all possible error codes related to serializing or deserializing CLP | ||
* IR streams. | ||
*/ | ||
enum class IrErrorCodeEnum : uint8_t { | ||
DecodingMethodFailure, | ||
EndOfStream, | ||
IncompleteStream, | ||
}; | ||
|
||
using IrErrorCode = clp::error_handling::ErrorCode<IrErrorCodeEnum>; | ||
} // namespace clp::ffi::ir_stream | ||
|
||
CLP_ERROR_HANDLING_MARK_AS_ERROR_CODE_ENUM(clp::ffi::ir_stream::IrErrorCodeEnum); | ||
|
||
#endif // CLP_IRERRORCODE_HPP |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try to be a bit more descriptive for these messages, since right now they just repeat the enum name for the most part. Ideally, we want the user to have some idea on where to look to understand the source of the error.
For example, for
EndOfStream
maybe:"The end-of-stream encoding tag has been consumed."
I'm not sure that is very good, but I think if we discuss for a bit we can come up with some better stuff.