Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(boost): Update Boost's source URL (fixes #649). #650

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Jan 3, 2025

Description

This PR updates Boost's source URL as suggested in boostorg/boost#997.

Validation performed

Validated that the clp-core-build workflow succeeds.

Summary by CodeRabbit

  • Chores
    • Updated the download URL for Boost library source code from JFrog Artifactory to Boost archives site
    • Maintained existing script functionality for Boost library installation

Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Walkthrough

The pull request modifies the install-boost.sh script to update the download URL for Boost library source code. The change replaces the JFrog Artifactory URL with a new URL from Boost archives. This modification ensures that the script can continue downloading the Boost library tarball from a reliable source. The core functionality of the script remains unchanged, with only the download location being updated.

Changes

File Change Summary
components/core/tools/scripts/lib_install/install-boost.sh Updated Boost library download URL from JFrog Artifactory to Boost archives

Possibly related issues

  • y-scope/clp#649: Directly addresses the issue of an invalid Boost source URL by updating the download location to a working archives site.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 329edf6 and 999e5c7.

📒 Files selected for processing (1)
  • components/core/tools/scripts/lib_install/install-boost.sh (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/core/tools/scripts/lib_install/install-boost.sh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the GH workflow should have validated 1.87.0, i ran sudo ./install-boost.sh 1.85.0 on a WSL Ubuntu 20.04 clean installation which was successful.
The changes and PR title lgtm

@kirkrodrigues kirkrodrigues merged commit 61f9902 into y-scope:main Jan 3, 2025
18 checks passed
@kirkrodrigues kirkrodrigues deleted the fix-649 branch January 3, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants