-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(clang-format): Update to clang-format v19 (and the corresponding yscope-dev-utils) and apply the corresponding formatting changes (fixes #545). #658
Conversation
WalkthroughThe pull request introduces a comprehensive set of formatting changes across multiple components of the codebase. These modifications primarily focus on improving code readability by adjusting method signatures, constructor definitions, and function declarations. The changes are purely stylistic and do not alter the underlying functionality, logic, or control flow of the code. The most common modifications include removing unnecessary semicolons, consolidating or breaking method signatures across lines, and ensuring consistent formatting across different files and classes. Changes
Sequence DiagramSince the changes are primarily formatting-related and do not introduce new functionality or modify control flow, a sequence diagram is not applicable in this case. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (12)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
This PR updates yscope-dev-utils to the latest commit so that clang-format v19 config can be used. It also updates clang-format version to v19 in the linter dependency to format C++ code using the latest clang-format pypi release.
Validation performed
Summary by CodeRabbit
Release Notes
Style
Dependency Updates
clang-format
version requirement to >=19.1.6Subproject Updates
tools/yscope-dev-utils
subproject referenceThese changes primarily focus on code style consistency and minor dependency management, with no significant functional modifications to the codebase.