Expand functionality: limit group for adapter

[killondark]

Hey, @Envek. In continue my PR. I want to extend the metrics limit functionality for the adapter.

# current version:
Yabeda.configure do
  group :mushrooms do
    adapter :basket_adapter
    counter :champignon_counter
  end
end

# added version:
Yabeda.configure do
  group :mushrooms do
    counter :champignon_counter
  end

  adapter :basket_adapter do
    include_group :mushrooms
  end
end

But specs do randomly green or red. For example:

1) Yabeda::Counter when config has no group execute perform_counter_increment!
   Failure/Error: let(:counter) { Yabeda.test_counter }
   
   NoMethodError:
     undefined method `test_counter' for Yabeda:Module
   # ./spec/yabeda/counter_spec.rb:14:in `block (3 levels) in <top (required)>'
   # ./spec/yabeda/counter_spec.rb:4:in `block (2 levels) in <top (required)>'
   # ./spec/yabeda/counter_spec.rb:30:in `block (3 levels) in <top (required)>'

What do you think about this? Thanks.

[killondark]

Hi, @Envek. I done actualize and fixed failing specs. Running specs randomly is was a problem.

[Envek]

Thanks for the pull request and sorry for the late reply. I will try to get to this in a few days.

[Envek]

It is not good when test suite result depends on order in which tests are executed. These dependencies need to be detected and removed (maybe something need to be added to the Yabeda.reset!)

[killondark]

I agree, it just solved my problem. Reverted it.

[Envek]

Thanks for the pull request. There are some small tweaks and rewording needed, but otherwise it looks good.

[Envek]

I'm a bit worried that this instance variable is being kept defined after adapter method has ended. While it should be harmless now, it can possibly create problems in the future. Let's clear it in the ensure block maybe?

[killondark]

Done.

[Envek]

That error message isn't very helpful because it doesn't tell what is wrong with this call to the adapter method and how to fix it.

Should be something like following, I think:

Yabeda.adapter should be called either inside group declaration or should have block provided with a call to include_group. No metric group provided.

[killondark]

Updated the message.