일기장 [Step3] RedMango, Minsup #141
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // | ||
| // WeatherFetcher.swift | ||
| // Diary | ||
| // | ||
| // Created by 김민성 on 2023/09/15. | ||
| // | ||
|
|
||
| import Foundation | ||
| import UIKit | ||
|
|
||
| struct WeatherFetcher { | ||
| let locationManager: LocationManager | ||
|
|
||
| init(locationManager: LocationManager = LocationManager()) { | ||
| self.locationManager = locationManager | ||
| } | ||
|
|
||
| func fetch(_ completion: @escaping (Data?) -> Void) { | ||
| locationManager.fetchSingleLocation { location in | ||
| Task { | ||
|
Comment on lines
+18
to
+20
There was a problem hiding this comment. location을 전달받을 때 꼭 클로저로 전달받아야 하나요? |
||
| do { | ||
| let weather = try await NetworkManager.fetchCurrentWeather(coordinate: location.coordinate) | ||
|
|
||
| let icon = try await NetworkManager.fetchWeatherIcon(icon: weather?.icon) | ||
| completion(icon) | ||
| } catch { | ||
| completion(nil) | ||
| } | ||
|
Comment on lines
+21
to
+28
There was a problem hiding this comment. NetworkManager 내의 fetch~ 메서드들은 throws로 에러를 던지고있는데, There was a problem hiding this comment. 그리고 해당 객체는 |
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="21513" systemVersion="21G651" minimumToolsVersion="Automatic" sourceLanguage="Swift" userDefinedModelVersionIdentifier=""> | ||
| <entity name="Diary" representedClassName="Diary" syncable="YES" codeGenerationType="class"> | ||
| <attribute name="content" optional="YES" attributeType="String"/> | ||
| <attribute name="createdDate" optional="YES" attributeType="Date" usesScalarValueType="NO"/> | ||
| <attribute name="title" optional="YES" attributeType="String"/> | ||
| <attribute name="weatherImage" optional="YES" attributeType="Binary"/> | ||
| </entity> | ||
| </model> |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WeatherFetcher내에서 현재의 경,위도 정보만 필요한거라면해당 값만 주입받는 방법은 어떨까요?
LocationManager객체 자체를 들고있기엔 현재 구조체의 기능이나 책임이 조금 모호하게 비대한 느낌이 들어요