bugfix: when clicking anywhere on the screen there was an error in th…

…e console
yairEO · Aug 27, 2019 · 70bfa37 · 70bfa37
1 parent 416b49f
commit 70bfa37
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -252,7 +252,7 @@ the same values that appear between `[[` & `]]`.
 
 A Tagify React component is exported as `<Tags>` from [`react.tagify.js`](https://github.com/yairEO/tagify/blob/master/dist/react.tagify.js):
 
-Check the [**codepen demo**](https://codepen.io/vsync/project/editor/ARaJye) for a live React integration example
+Check the [**live demo**](https://codesandbox.io/s/tagify-react-wrapper-6vd3i) for a live React integration example
 
 
 ## Angular

diff --git a/dist/jQuery.tagify.min.js b/dist/jQuery.tagify.min.js
diff --git a/dist/tagify.js b/dist/tagify.js
@@ -1,5 +1,5 @@
 /**
- * Tagify (v 2.25.1)- tags input component
+ * Tagify (v 2.25.3)- tags input component
  * By Yair Even-Or
  * Don't sell this code. (c)
  * https://github.com/yairEO/tagify
@@ -1277,11 +1277,11 @@ Tagify.prototype = {
           var value, listItemElm;
           if (e.button != 0 || e.target == this.DOM.dropdown) return; // allow only mouse left-clicks
 
-          listItemElm = e.target.closest(".tagify__dropdown__item"); // make sure the list item belongs to this context of the Tagify instance (and not some other instance's manual suggestions list)
-
-          if (listItemElm.parentNode !== this.DOM.dropdown) return;
+          listItemElm = e.target.closest(".tagify__dropdown__item");
 
           if (listItemElm) {
+            // make sure the list item belongs to this context of the Tagify instance (and not some other instance's manual suggestions list)
+            if (listItemElm.parentNode !== this.DOM.dropdown) return;
             value = this.suggestedListItems[this.getNodeIndex(listItemElm)] || this.input.value;
             this.addTags([value], true);
             setTimeout(function () {

diff --git a/dist/tagify.min.js b/dist/tagify.min.js
diff --git a/src/tagify.js b/src/tagify.js
@@ -1302,11 +1302,12 @@ Tagify.prototype = {
 
                     listItemElm = e.target.closest(".tagify__dropdown__item");
 
-                    // make sure the list item belongs to this context of the Tagify instance (and not some other instance's manual suggestions list)
-                    if( listItemElm.parentNode !== this.DOM.dropdown )
-                        return
 
                     if( listItemElm ){
+                        // make sure the list item belongs to this context of the Tagify instance (and not some other instance's manual suggestions list)
+                        if( listItemElm.parentNode !== this.DOM.dropdown )
+                            return
+
                         value = this.suggestedListItems[this.getNodeIndex(listItemElm)] || this.input.value;
                         this.addTags([value], true);