Allowing complete control of the axios instance at the request level (so we can use any axios feature) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retries 3 times by default, and only on network errors and 5xx errors on indempotent requests (GET, HEAD, OPTIONS, PUT, or DELETE).
Update comments
Also added lodash which will be necessary for the next commit (using lodash merge). This won't add overhead since it looks like lodash is already in use indirectly by a dependency (I see it in the package-lock.json file)
this allows users to control axios arguments at the action/request level (e.g. specify timeouts)
…into add-axios-arg
|
To be honest I'd rather just release a major version with the breaking change than have all this cruft in the code to deal with backwards compatibility. But I'll defer to the others opinions on that. |
|
@odensc I agree that it'll look cleaner without the backwards compatibility, but I'd wait on a few other potentially breaking changes before releasing the next major update: rewriting b2.js with an ES6 class and (if possible) removing of the .authorize() call and managing that automatically/internally as requested in #56 |
This was referenced Feb 20, 2019
yakovkhalinsky
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates, no breaking changes:
axiosandaxiosOverrideconfig arguments that allow complete control of the axios instance at the request level so we can use any axios feature (including the timeouts in timeout arg for file actions #49 )function(b2, args)while retaining backwards compatibility - necessary for addingaxiosandaxiosOverrideargs.