Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-363: Design: Serif text in right column gets cut off | YALB-365: Design: Grand Hero Banner overlay header spacing | YALB-424: Removing primary-nav and grand hero results in missing fontawesome #211

Merged
merged 3 commits into from
Mar 22, 2024
Merged

YALB-363: Design: Serif text in right column gets cut off | YALB-365: Design: Grand Hero Banner overlay header spacing | YALB-424: Removing primary-nav and grand hero results in missing fontawesome #211

merged 3 commits into from
Mar 22, 2024

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Mar 12, 2024 •
edited
Loading

YALB-363: Design: Serif text in right column gets cut off

YALB-365: Design: Grand Hero Banner overlay header spacing

YALB-424: Removing primary-nav and grand hero results in missing fontawesome

Description of work

  • YSP-363: Adds overflow override to text component in second column so the serif along the left side doesn't get cut off.
  • YSP-365: Adds conditional check for grand hero content so the markup for grand hero content doesn't render, causing the gap flex spacing to add more space when only the heading is present
  • YSP-424: Adds fontawesome library in atomic.yml file and removes the attach statements from block templates
  • Adds a template (templates/field/field--block-content--text.html.twig) to remove extra div element around text content fields.

Testing Link(s)

@joetower joetower self-assigned this Mar 12, 2024
@joetower joetower marked this pull request as ready for review March 13, 2024 15:42
@joetower joetower changed the title feat(YSP-363): fix overflow issue hiding h2 in second column, add tem… YALB-363: Design: Serif text in right column gets cut off | YALB-365: Design: Grand Hero Banner overlay header spacing | YALB-424: Removing primary-nav and grand hero results in missing fontawesome Mar 13, 2024
dblanken-yale
dblanken-yale approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in main PR. Nice work.

codechefmarc
codechefmarc approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested over on component library. Approved.

@nJim nJim merged commit 68c0528 into develop Mar 22, 2024
@nJim nJim deleted the YSP-363-365-426-bugs branch March 22, 2024 15:02
@vinmassaro vinmassaro mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codechefmarc codechefmarc codechefmarc approved these changes

@dblanken-yale dblanken-yale dblanken-yale approved these changes

@nJim nJim Awaiting requested review from nJim

Assignees

@joetower joetower

Labels
pass code review pass functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joetower @codechefmarc @dblanken-yale @nJim