Skip to content

Commit

Permalink
fix(YSP-353): override white footer link shadow (#337)
Browse files Browse the repository at this point in the history
When changing to a background that is not white, the links that are
decorated with underlines have an attribute of a white shadow on it.
This results in a terrible looking link.  The way this passed in the
past was that we had a white background with a white shadow, so it
looked ok.  This now mimics the same attempting to match the footer
background.  Right now we are just targeting the footer since it was
found only here, but it makes me wonder if we need the shadow?
  • Loading branch information
dblanken-yale authored Feb 26, 2024
1 parent d1d0676 commit 82e2c89
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions components/01-atoms/controls/text-link/_yds-text-link.scss
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ $global-link-themes: map.deep-get(tokens.$tokens, 'global-themes');
align-items: center;
width: fit-content;
background-size: calc(100% - var(--size-spacing-3)) var(--thickness);

// Footer elements with a dark background can't have white shadows
// so this overrides it to match the current background color of the footer.
.site-footer__secondary & {
--color-text-shadow: var(--color-site-footer-background-color);
}
}

&[data-link-style='no-underline'] {
Expand Down

0 comments on commit 82e2c89

Please sign in to comment.