YSP-352: Mobile menu hide animation on resize #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A loaded menu state is one where the page has been loaded, but no toggles have been made. This lets us take that into account and not display the visual rollup on a resize.
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The svg arrows were showing even though the menu was not. They no longer show.
If we resize the window again and the current state of the menu is closed, make it loaded so we don't get the roll up effect afterward. If it's open, leave it as is.
joetower
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@dblanken-yale This all looks good and accomplishes the goal. I can not think of a better way to do this nor can I think of any downsides to your approach here.
Lovely work!
|
@joetower Thanks so much. I added @kara-franco then to make sure there's no accessibility issues doing this or that she finds some way to get into the menu that I can't find. :D |
kara-franco
approved these changes
Mar 12, 2024
Merged
|
🎉 This PR is included in version 1.40.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-352: Mobile menu hide animation on resize
When resizing the window to a mobile size, the closed menu actually shows temporarily and then animates up to hide itself.
A loaded menu state is one where the page has been loaded, but no toggles have been made. This lets us take that into account and not display the visual rollup on a resize.
Description of work
loadedinitial menu state so that we can properly hide the menu on initial resizeloadedif it wasclosedTesting Link(s)
Functional Review Steps
Accessibility Review