YSP-426: Placement for the external link icon on footer logo #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mega footer allows images to be linked, which could be external, causing the external link to occur in some cases, which looks odd. This skips those and any that would contain an image inside of the link since it would look odd in most cases I can think of.
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
4 tasks
joetower
approved these changes
Mar 13, 2024
miketullo95
approved these changes
Mar 14, 2024
Merged
|
🎉 This PR is included in version 1.40.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-426: Placement for the external link icon on footer logo
The mega footer allows images to be linked, which could be external, causing the external link to occur in some cases, which looks odd. This skips those and any that would contain an image inside of the link since it would look odd in most cases I can think of.
Description of work
Testing Link(s)
Functional Review Steps