Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-413: Stats component | YSP-428: Tiles Components #346

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Mar 21, 2024

YSP-413: Stats component

YSP-428: Tiles Components

Description of work

  • Renames previous stat component infographic
  • Renames previous stats component infographic__group
  • Adds new component for tile-item
  • Adds new component for tiles

Testing Link(s)

Functional Review Steps

Testing re-named components (Stats -> Infographic)


Testing Tile Item component:

ysp-428-tile-item.mp4

Testing Tiles component

ysp-428-tiles.mp4

Design Review

  • Verify the designs match the Figma Designs
  • When Katy is back in the office (out of office until next week) I want to meet with here briefly to discuss the design implementation

Accessibility Review

  • Verify the component meets Accessibility requirements

@joetower joetower self-assigned this Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit 7b66e22
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/662280bc54ca5900083823a9
😎 Deploy Preview https://deploy-preview-346--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower changed the title YSP-413: Stats component YSP-413: Stats component | YSP-428: Tiles Components Mar 26, 2024
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Nice job!!!!!!

Copy link

@kara-franco kara-franco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, a11y approved!

Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This looks great, and a ton of options to really dial it all in to what you want. Great work. I played with many options, responsive, etc and all looked good. I didn't go too deep into the CSS, I'll trust you on that piece. Approved!

@nJim nJim merged commit 6eda323 into develop Apr 19, 2024
5 checks passed
@nJim nJim deleted the YSP-413-stats branch April 19, 2024 16:49
@nJim nJim mentioned this pull request Apr 19, 2024
Copy link

🎉 This PR is included in version 1.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants