Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix completion #7

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Fix completion #7

merged 2 commits into from
Jan 30, 2018

Conversation

astyagun
Copy link
Contributor

@astyagun astyagun commented Jan 28, 2018 •
edited
Loading

Not sure how this syntax works or if this is even a good idea to make this change, but it fixed completion for me. Omni function I'm using is here: https://github.com/astyagun/dotvim/blob/e0442d56873312b53d9914776d028f82d97d2fe8/my_plugin/global_complete.vim

@astyagun
Fix completion
ff36eb8 
Not sure how this syntax works or if this is even a good idea to make this change, but it fixed completion for me. Omni function I'm using is here: https://github.com/astyagun/dotvim/blob/fee9bf53c2b7b5311b00316b21fe3bc6a1d321ef/my_plugin/global_complete.vim
@astyagun
Copy link
Contributor Author

After reading #2 and #3 I'll add, that I'm running MacVim:

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec 22 2017 03:30:17)
macOS version
Included patches: 1-1420

@astyagun
Copy link
Contributor Author

My guess is that 'omnifunc' in issue #2 returned incorrect start position when called with first argument equal 0. Assuming that my current 'omnifunc' returns correct start position.

@yami-beta
Copy link
Owner

I confirmed your PR works correctly.
Thanks !

@yami-beta yami-beta merged commit a7ecf4e into yami-beta:master Jan 30, 2018
@astyagun astyagun deleted the patch-1 branch January 30, 2018 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astyagun @yami-beta