Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to poetry #191

Merged
merged 22 commits into from
Mar 15, 2024
Merged

Migrate to poetry #191

merged 22 commits into from
Mar 15, 2024

Conversation

hendzeld
Copy link
Contributor

@hendzeld hendzeld commented Mar 6, 2024

Migrate from Setuptools to Poetry

hendzeld added 14 commits March 6, 2024 20:23
Commands:
poetry config virtualenvs.create true --local
poetry config virtualenvs.in-project true --local
With commands:
cat requirements.txt | grep -v '#' | xargs poetry add
cat test_requirements.txt | grep -v '#' | xargs poetry add --group test
Move tool.project sections to tool.poetry
@hendzeld hendzeld self-assigned this Mar 6, 2024
@hendzeld hendzeld marked this pull request as ready for review March 6, 2024 21:37
@hendzeld hendzeld requested a review from grzanka March 6, 2024 21:37
README.md Outdated Show resolved Hide resolved
hendzeld and others added 2 commits March 7, 2024 16:42
Co-authored-by: Leszek Grzanka <[email protected]>
@hendzeld
Copy link
Contributor Author

@grzanka

I tried to run this branch in UI.

Unfortunately, it doesn't work for now.

I read Pyodide documentation, and it can load public packages but only for pure-Python packages.
This means wheels with the *-none-any.whl suffix.
More here:

Unfortunately, SciPy doesn't provide such package.
It took me some time to realise that Pyodide has some packages already pre-build.
Old version used in UI importScripts('https://cdn.jsdelivr.net/pyodide/v0.21.3/full/pyodide.js'); uses SciPy in version 1.8.1 according to this list: https://pyodide.org/en/0.21.3/usage/packages-in-pyodide.html#packages-built-in-pyodide

We can update Pyodide to the latest version (0.25.0) for now.
It uses SciPy in version 1.11.2, according to: https://pyodide.org/en/0.25.0/usage/packages-in-pyodide.html

I will lock version of SciPy in converter for now to 1.11.2

Message:
Because yaptide-converter depends on scipy (1.11.2) which requires Python <3.13,>=3.9, version solving failed.

Pyodide 0.25.0:
https://pyodide.org/en/0.25.0/usage/packages-in-pyodide.html
@grzanka
Copy link
Contributor

grzanka commented Mar 13, 2024

@hendzeld another idea would be to get rid of scipy. It is being used only to handle rotation matrix. That could be moved to pure-python code.

@hendzeld
Copy link
Contributor Author

@hendzeld another idea would be to get rid of scipy. It is being used only to handle rotation matrix. That could be moved to pure-python code.

Maybe we should do this in in a different PR.

Regarding current version:
I tested this version on UI.
It seems to work, I will create a draft PR in the UI repository.

obraz

obraz

@grzanka
Copy link
Contributor

grzanka commented Mar 13, 2024

@hendzeld another idea would be to get rid of scipy. It is being used only to handle rotation matrix. That could be moved to pure-python code.

Maybe we should do this in in a different PR.

Good, we can separate the issues.

Anyway thanks for deep inspection of the issue !

@grzanka grzanka merged commit 83b956c into master Mar 15, 2024
10 checks passed
@grzanka grzanka deleted the migrate-to-poetry branch March 15, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants