Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add focus to editor container (#227) #232

Merged
merged 3 commits into from
Nov 4, 2021
Merged

add focus to editor container (#227) #232

merged 3 commits into from
Nov 4, 2021

Conversation

ostatni5
Copy link
Member

@ostatni5 ostatni5 commented Nov 4, 2021 •
edited
Loading

close #227

@ostatni5 ostatni5 added this to the MS 2 milestone Nov 4, 2021
@ostatni5 ostatni5 requested a review from Derstilon November 4, 2021 10:25
@ostatni5 ostatni5 self-assigned this Nov 4, 2021
Derstilon
Derstilon reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to fix this issue with focus as well?
#189
Can you add focus to Clipping plane UI and disable keyboard events in the viewport?

@grzanka
Copy link
Contributor

grzanka commented Nov 4, 2021

@ostatni5 I leave the review to others as the issue is somehow far from my focus

@ostatni5
Copy link
Member Author

ostatni5 commented Nov 4, 2021

Is it possible to fix this issue with focus as well? #189 Can you add focus to Clipping plane UI and disable keyboard events in the viewport?

No

@ostatni5 ostatni5 merged commit c0c18ad into master Nov 4, 2021
@ostatni5 ostatni5 deleted the fix/227-user-focus branch November 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derstilon Derstilon Derstilon approved these changes

Assignees

@ostatni5 ostatni5

Labels
None yet
Projects
None yet
Milestone
MS 2
Development

Successfully merging this pull request may close these issues.

Fix input interception from threeJS editor when it's not selected in the wrapper app
3 participants
@ostatni5 @grzanka @Derstilon