oop task done #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yamnich
reviewed
Dec 2, 2016
| end | ||
|
|
||
| def most_active_reader | ||
| data_module.fetch_orders.group_by { |order| order.reader }.sort_by { |_, value| value.length }.to_a.last.first |
|
|
||
| def three_popular_books_orders | ||
| books = group_orders_by_books.last(3).map { |item| item.first } | ||
| book_ids = books.map { |book| book.id } |
| else | ||
| nil | ||
| end | ||
| end |
There was a problem hiding this comment.
Now method is very long and are several extra actions
There are several possibilities here:
- data_module.fetch_orders.select { |order| book_ids.include? order.book.id }.map(&:reader)
- data_module.fetch_orders.map { |order| order.reader if book_ids.include? order.book.id }.compact
According to task you should return count of uniq readers who takes at least one of 3 most popular books. Are you sure that you need to return books and readers.
Also you don't need to use return in the line 30
| private | ||
|
|
||
| def group_orders_by_books | ||
| data_module.fetch_orders.group_by { |order| order.book }.sort_by { |_, value| value.length }.to_a |
yamnich
approved these changes
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.