Skip to content

Commit

Permalink
Remove 'scc-codestyle' from dependencies
Browse files Browse the repository at this point in the history
This commit removes the gem 'scc-codestyle' from the project, and adds
'rubocop-rspec' as a direct dependency to continue having the a similar
set of linter rules.

The 'scc-codestyle' version in use was too outdated, and updating it to
a newer one would require a heavy restyling of the code.
  • Loading branch information
lcaparroz committed Mar 18, 2024
1 parent 751d2e1 commit 3886a70
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
14 changes: 3 additions & 11 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,16 @@
# Rubocop version is locked in the dependencies of scc-codestyle gem.
# The version of scc-codestyle gem is specified in the Dockerfile.
inherit_gem:
scc-codestyle:
- default.yml
require:
- rubocop-rspec

inherit_from: .rubocop_todo.yml

AllCops:
Include:
- Gemfile
- config.ru
NewCops: disable
Exclude:
- .bundle/**/*
- vendor/**/*
- package/*
- Rakefile

Rails:
Enabled: false

# Impossible to satisfy these rules in specs
RSpec/ExpectInHook:
Enabled: false
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ gem 'yast-rake', '~> 0.2.20'

group :development do
gem 'gettext'
gem 'scc-codestyle', '~> 0.1.4'
gem 'rubocop-rspec', '~> 1.19.0'
end
5 changes: 1 addition & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ GEM
rubocop-rspec (1.19.0)
rubocop (>= 0.51.0)
ruby-progressbar (1.9.0)
scc-codestyle (0.1.4)
rubocop (= 0.52.1)
rubocop-rspec (= 1.19)
text (1.3.1)
unicode-display_width (1.3.0)
yast-rake (0.2.20)
Expand All @@ -38,7 +35,7 @@ PLATFORMS

DEPENDENCIES
gettext
scc-codestyle (~> 0.1.4)
rubocop-rspec (~> 1.19.0)
yast-rake (~> 0.2.20)

BUNDLED WITH
Expand Down

0 comments on commit 3886a70

Please sign in to comment.