Fix unstranlated strings

[lcaparroz]

Problem

Some strings in the UI dialogs are not translated, resulting in text being shown partially in the configured locale language, partially in English.

The issue was originally reported for the Simplified Chinese language, but it can also be replicated for Brazilian Portuguese, leading to infer that probably all translations are affected by the same issue.

Cause

The strings not being translated are marked with the function N_(...), assigned to instance variables that would later be localized with the function _(...), which is quite common when using the gettext Ruby gem.

However, the cause is that the y2tools y2makepot command, used to identify localized strings, doesn't consider the function N_(...) when scanning the files (source code).

• Bugzilla link: https://bugzilla.suse.com/show_bug.cgi?id=1127676
• openQA link: https://openqa.suse.de/tests/15854944

Solution

We changed the code to no longer use the function N_(...), only _(...), and adapted the classes that relied on receiving strings with N_(...) through instance variables.

Testing

• No new unit tests were added: it's only a change to how string localization is handled.
• It will only be possible to test the effects of this change after a new translation round:
  • Submitting new strings for translation (i18n).
  • Asking for the translation of those strings.
  • Bundling the new translations in the yast2-rmt package.

Meanwhile, you can verify that files previously not considered for translation are caught by the command rake check:pot:

• src/lib/rmt/maria_db/current_root_password_dialog.rb
• src/lib/rmt/maria_db/new_root_password_dialog.rb
• src/lib/rmt/ssl/current_ca_password_dialog.rb
• src/lib/rmt/ssl/new_ca_password_dialog.rb

Output example from running rake check:pot:

$ rake check:pot
/usr/bin/y2tool y2makepot
Creating ./rmt.pot from  ./src/lib/rmt/execute.rb ./src/lib/rmt/maria_db/current_root_password_dialog.rb ./src/lib/rmt/maria_db/new_root_password_dialog.rb ./src/lib/rmt/shared/input_password_dialog.rb ./src/lib/rmt/shared/set_password_dialog.rb ./src/lib/rmt/ssl/alternative_common_name_dialog.rb ./src/lib/rmt/ssl/certificate_generator.rb ./src/lib/rmt/ssl/current_ca_password_dialog.rb ./src/lib/rmt/ssl/new_ca_password_dialog.rb ./src/lib/rmt/utils.rb ./src/lib/rmt/wizard_final_page.rb ./src/lib/rmt/wizard_firewall_page.rb ./src/lib/rmt/wizard_maria_db_page.rb ./src/lib/rmt/wizard_rmt_service_page.rb ./src/lib/rmt/wizard_scc_page.rb ./src/lib/rmt/wizard_ssl_page.rb ...
rmt.pot: 3 format flags added
Verifying rmt.pot validity...
rmt.pot:8: warning: header field 'Project-Id-Version' still has the initial default value
rmt.pot:8: warning: header field 'Last-Translator' still has the initial default value
rmt.pot:8: warning: header field 'Language-Team' still has the initial default value
rmt.pot:8: warning: header field 'Language' still has the initial default value
...OK
Checking rmt.pot...

You can also read the generated rmt.pot file and verify that the strings previously marked with N_(...) (see the "Files changed" tab) are present there, e.g.:

#: src/lib/rmt/maria_db/current_root_password_dialog.rb:31
msgid "Database root password is required"
msgstr ""

#: src/lib/rmt/maria_db/current_root_password_dialog.rb:32
msgid ""
"In order to setup RMT, database access is required. Please provide the current"
" database root password."
msgstr ""

#: src/lib/rmt/maria_db/current_root_password_dialog.rb:33
msgid "MariaDB root &password"
msgstr ""

Screenshots

N/A.

[coveralls]

Pull Request Test Coverage Report for Build 13679662955

Details

• 18 of 18 (100.0%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 98.56%

---

Totals
Change from base Build 10734341110:	0.004%
Covered Lines:	1643
Relevant Lines:	1667

---

💛 - Coveralls