Skip to content

Commit

Permalink
onpanic: add support for multipathed zfcp-attached SCSI disks
Browse files Browse the repository at this point in the history
Depends on https://build.opensuse.org/package/show/Base:System/s390-tools
commit ("mkdump: add support for multipathed zfcp-attached SCSI disks")
from SUSE bug 1216257.

Users should use multipathing for all zfcp-attached SCSI disks.
Since a long time, zipl can write the partition-based zfcpdump
standalone dumper boot record to a multipath device.
This avoids users having to flush multipath maps or maintain
a multipath exception list just for zfcp dump volumes.
Always having multipathing for everything also provides redundant
access to the dump volume on importing the dump from the volume into
a filesystem after the standalone dumper had written the dump.

An updated mkdump.pl from SUSE s390-tools understands and lists such
multipath devices. Make "yast onpanic" understand /dev/mapper/... multipath
devices as better alternative to single path SCSI disks /dev/sd[a-z]+.

Fixes SUSE bug 1020336.

Signed-off-by: Steffen Maier <[email protected]>
  • Loading branch information
steffen-maier committed Dec 13, 2023
1 parent 77e8cf1 commit 2336d13
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/modules/OnPanic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def ConvertMkdumpToConf(dev_line)
Ops.get(entry, 0),
"^/dev/dasd[[:lower:]]+$"
)
is_zfcp = Builtins.regexpmatch(Ops.get(entry, 0), "^/dev/sd[[:lower:]]+$")
is_zfcp = Builtins.regexpmatch(Ops.get(entry, 0), "^/dev/(sd[[:lower:]]+|mapper/.*)$")

if is_dasd
dev = Builtins.add(dev, "DUMP_TYPE", "ccw")
Expand Down Expand Up @@ -135,7 +135,7 @@ def ConvertConfToMkdump(dev)
Ops.get(line, 2) == Ops.get(dev, "DEVICE") ||
# check for fitting zfcp
type == "fcp" &&
Builtins.regexpmatch(Ops.get(line, 0), "^/dev/sd[[:lower:]]+") &&
Builtins.regexpmatch(Ops.get(line, 0), "^/dev/(sd[[:lower:]]+|mapper/)") &&
Ops.get(line, 2) == Ops.get(dev, "DEVICE") &&
Ops.get(line, 3) == Ops.get(dev, "WWPN") &&
Ops.get(line, 4) == Ops.get(dev, "LUN") # check for fitting dasd
Expand Down

0 comments on commit 2336d13

Please sign in to comment.