Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current device to the tables #1138

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Sep 21, 2020

Problem

As part of the new Partitioner UI, the current device should be included in all its tables. For example, when we go to a specific MD, the table for its partitions shows the MD device as well.

NOTE: this is only a first step. The resulting UI would use nesting rows with the current device as root. But nesting tables is still a WIP feature in libyui, see https://github.com/libyui/libyui/pull/171.

Solution

Add the current device to all the tables where it is needed:

  • In the partitions of a device (disk, MD, Bcache).
  • In the used devices of a BIOS RAID, Multipath, MD, Bcache, Btrfs
  • In the Logical Volumes of a VG
  • In the Physical Volumes of a VG.

Testing

  • Added new unit tests
  • Tested manually

Screenshots

Screenshot from 2020-09-22 00-46-02

@joseivanlopez joseivanlopez changed the base branch from master to partitioner-ui-02 September 21, 2020 14:28
@joseivanlopez joseivanlopez changed the title Add current device to lists Add current device to the lists Sep 21, 2020
@coveralls
Copy link

coveralls commented Sep 21, 2020

Coverage Status

Coverage decreased (-0.0007%) to 97.075% when pulling b9034c7 on joseivanlopez:add_current_device into bf6daa8 on yast:partitioner-ui-02.

@joseivanlopez joseivanlopez marked this pull request as ready for review September 21, 2020 23:46
@joseivanlopez joseivanlopez changed the title Add current device to the lists Add current device to the tables Sep 21, 2020
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 24ec0af into yast:partitioner-ui-02 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants