Tiny internal code reorganization to ease Agama development #1386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agama-project/agama#1448 introduces a new approach to manage storage devices at Agama. Instead of relying on the Y2Storage proposals living in this repository, that PR introduces a new
Y2Storage::AgamaProposal
class living at the Agama repository.That new proposal needs to:
SpaceMaker
does not clean up the attribute#forced_ptable_type
for all devices just for the sake of it (it doesn't seem to be a clear need for such initialization).All that could be fixed on the Agama side:
SpaceMaker
method can be redefined by the Agama proposal to leave out the excessive initialization.But this PR offers an alternative by modifying the code directly at the yast2-storage-ng repository, which may be considered cleaner.