Using BLS bootloader as default.

[schubi2]

Problem

We need BLS bootloader in the future as the default bootloader:
https://news.opensuse.org/2024/10/08/grub2-bls
BLS suggests 1GiB for boot partition:
yast/yast-bootloader#708
So, in that case we are reserving this space.

This can be disabled with YAST_NO_BLS_BOOT=1

Testing

• Added a new unit test
• Tested manually

[coveralls]

coverage: 97.817% (+0.003%) from 97.814%
when pulling 5de0add on bls
into 00c076d on master.

[ancorgs]

Something very important. You modified boot_requirements_checker_x86_test.rb but I'm pretty sure there are more architectures affected. Please update all the relevant tests and re-generate the boot requirements document. It's crucial to keep that document in sync with the code.

You can do it by running

rake doc:bootspecs

And please then read the content to verify the behavior in all architectures is what you expect. That document is our contract signed with blood (and it will also contain your blood once this PR is merged) 😉

[ancorgs]

Something very important. You modified boot_requirements_checker_x86_test.rb but I'm pretty sure there are more architectures affected.

Hmmm, I was checking the document now and I found the size of the EFI partition for aarch is indeed not mentioned there. We should add it, similar to the x86 and Raspberry Pi cases which both have a subsection saying "when proposing a new EFI partition...".

BTW, as you can see in that document the EFI size for Raspberry Pi is not modified as part of this PR. Is that intentional?

[ancorgs]

Another consideration. I see this new strategy reuses the original criteria of BootRequirementsStrategies::UEFI to reuse an existing EFI partition (if the user chose a non-aggressive approach to make space). As you can see here, such criteria do not include the size. EFI partitions will be re-used (eg. shared with a pre-existing operating system) if they look like a sane EFI, no matter the size.

[ancorgs]

Another general question. What's the plan for Raspberry Pi?

[schubi2]

Another general question. What's the plan for Raspberry Pi?

Currently only x86 and aarch64 will be supported.

[schubi2]

Something very important. You modified boot_requirements_checker_x86_test.rb but I'm pretty sure there are more architectures affected.

Hmmm, I was checking the document now and I found the size of the EFI partition for aarch is indeed not mentioned there. We should add it, similar to the x86 and Raspberry Pi cases which both have a subsection saying "when proposing a new EFI partition...".

I have added it for aarch64.

BTW, as you can see in that document the EFI size for Raspberry Pi is not modified as part of this PR. Is that intentional?

For the first step we are supporting x86 and aarch64 only.

[schubi2]

Another consideration. I see this new strategy reuses the original criteria of BootRequirementsStrategies::UEFI to reuse an existing EFI partition (if the user chose a non-aggressive approach to make space). As you can see here, such criteria do not include the size. EFI partitions will be re-used (eg. shared with a pre-existing operating system) if they look like a sane EFI, no matter the size.

Hm, I am not sure what's the right way here. I would allow it. But I am not an expert here. What's your opinion ?