Fix regular expression for core types and add test #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
requested changes
Aug 5, 2024
There was a problem hiding this comment.
@gemmaro Thanks for the pull request. The regex fix looks good, but the CI fails due to the new test.
It'd be helpful if you could separate the bug fix from the test addition. 🙏🏼
* rbs-mode.el (rbs-mode--core-type-regexp): Add word end pattern at the end of this regular expression. * CHANGELOG.md: Add a change log entry.
|
@ybiquitous Thank you for the pointer. I tweaked the GitHub Actions settings and splitted into several commits. |
ybiquitous
requested changes
Aug 5, 2024
* rbs-mode-test.el: Add regression tests for core type regexp. * .github/workflows/test.yml: Add GitHub Actions settings for ERT [1]. The first elisp-check is for linting source [2]. [1] https://github.com/leotaku/elisp-check#tests [2] https://github.com/leotaku/elisp-check/blob/b931bcc80dbd7e6dd8b3fa05fecd899025bcb811/index.js#L14-L25 Co-authored-by: Masafumi Koba <https://github.com/ybiquitous>
* Makefile (check): Add a task. * .editorconfig: Add EditorConfig settings for Makefile.
|
@ybiquitous I updated the test file to load |
ybiquitous
changed the title
|
https://github.com/ybiquitous/rbs-mode/releases/tag/v0.3.2 is released! 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This updates the regular expression for core types.
It makes, for example, not to recognize
StringScannerasString(core type) andScanner.Thanks,