Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove warning while using pandas is_categorical_dtype #1630

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: remove warning while using pandas is_categorical_dtype #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
448c880
fix: is_categorical_dtype is deprecated and will be removed in a futu…
quant12345 Jul 16, 2024
25fad43
Merge branch 'develop' into fix/categorical
fabclmnt Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ydata_profiling/model/typeset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def get_relations() -> Sequence[TypeRelation]:
@series_handle_nulls
def contains_op(series: pd.Series, state: dict) -> bool:
return (
not pdt.is_categorical_dtype(series)
not isinstance(series.dtype, pd.CategoricalDtype)
and pdt.is_string_dtype(series)
and series_is_string(series, state)
)
Expand Down Expand Up @@ -205,9 +205,9 @@ def get_relations() -> Sequence[TypeRelation]:
@series_not_empty
@series_handle_nulls
def contains_op(series: pd.Series, state: dict) -> bool:
is_valid_dtype = pdt.is_categorical_dtype(series) and not pdt.is_bool_dtype(
series
)
is_valid_dtype = isinstance(
series.dtype, pd.CategoricalDtype
) and not pdt.is_bool_dtype(series)
if is_valid_dtype:
return True
return False
Expand Down
2 changes: 1 addition & 1 deletion src/ydata_profiling/model/typeset_relations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def string_is_bool(series: pd.Series, state: dict, k: Dict[str, bool]) -> bool:
def tester(s: pd.Series, state: dict) -> bool:
return s.str.lower().isin(k.keys()).all()

if pdt.is_categorical_dtype(series):
if isinstance(series.dtype, pd.CategoricalDtype):
return False

return tester(series, state)
Expand Down
Loading