feat: migrate Bootstrap from 3.3.7 to 5.3.3 #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @leovan , can you please attach an html report that would result of using this branch to generate a profile report? That would ease the PR review from a functional perspective. |
fabclmnt
reviewed
Oct 15, 2024
|
|
||
| @property | ||
| def alert_type_name(self) -> str: | ||
| return self.alert_type.name.replace("_", " ").lower().title() | ||
| return self.alert_type.name.replace("_", " ").capitalize() |
fabclmnt
changed the title
|
Also change the PR title to follow the expected naming and convention of the package. Otherwise this would break the release and computation of the release version. Added |
All examples were tested with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config_fileabbrwithtooltipcodewithbadgewhen showing alert