Skip to content

Commit

Permalink
CHANGELOG and comment
Browse files Browse the repository at this point in the history
  • Loading branch information
asmyasnikov committed Jan 29, 2025
1 parent e90761a commit d1870fe
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
* Added `ydb.WithExecuteDataQueryOverQueryClient(bool)` option for execute data queries from table service client using query client API
* Added `ydb.WithExecuteDataQueryOverQueryClient(bool)` option to execute data queries from table service
client using query client API. Using this option you can execute queries from legacy table service client
through `table.Session.Execute` using internal query client API without limitation of 1000 rows in response.
Be careful: an OOM problem may happen because bigger result requires more memory

## v3.98.0
* Supported pool of encoders, which implement ResetableWriter interface
Expand Down
6 changes: 4 additions & 2 deletions options.go
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,10 @@ func WithSessionPoolIdleThreshold(idleThreshold time.Duration) Option {
}
}

// WithExecuteDataQueryOverQueryClient overrides table.Session.Execute with query service
// execute with materialized result
// WithExecuteDataQueryOverQueryClient option enables execution data queries from legacy table service client over
// query client API. Using this option you can execute queries from legacy table service client through
// `table.Session.Execute` using internal query client API without limitation of 1000 rows in response.
// Be careful: an OOM problem may happen because bigger result requires more memory
func WithExecuteDataQueryOverQueryClient(b bool) Option {
return func(ctx context.Context, d *Driver) error {
d.tableOptions = append(d.tableOptions, tableConfig.ExecuteDataQueryOverQueryService(b))
Expand Down

0 comments on commit d1870fe

Please sign in to comment.