Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using ip address in discovery response. #322

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

dcherednik
Copy link
Member

This feature allow server to explicit show own ip address to set connection instead of DNS hostname resolving. Usefull in case of connection to k8s clusters where nodes (k8s pod) placed in cluster.local domain so external user has no ability to resolve it.

This feature allow server to explicit show own ip address to set connection
instead of DNS hostname resolving. Usefull in case of connection to k8s clusters
where nodes (k8s pod) placed in cluster.local domain so external user has no
ability to resolve it.
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (fef5bde) to head (ce9981a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...src/main/java/tech/ydb/core/impl/YdbDiscovery.java 55.55% 2 Missing and 2 partials ⚠️
...n/java/tech/ydb/core/impl/pool/EndpointRecord.java 71.42% 1 Missing and 1 partial ⚠️
...a/tech/ydb/core/impl/pool/NettyChannelFactory.java 0.00% 2 Missing ⚠️
.../ydb/core/impl/pool/ShadedNettyChannelFactory.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
+ Coverage     47.39%   47.40%   +0.01%     
- Complexity     1729     1732       +3     
============================================
  Files           305      305              
  Lines         12362    12380      +18     
  Branches       1233     1237       +4     
============================================
+ Hits           5859     5869      +10     
- Misses         6045     6049       +4     
- Partials        458      462       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 requested a review from alex268 September 27, 2024 15:03
@alex268 alex268 merged commit a133f3d into ydb-platform:master Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants