Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EditorConfig configuration #340

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Myllyenko
Copy link

In this PR, I've added an EditorConfig configuration that enables usage of Intellij autoformatting in accordance with configured Checkstyle rules and existing code style. It will help newcomers to avoid Checkstyle issues.

@pnv1
Copy link
Collaborator

pnv1 commented Oct 28, 2024

Isn't trailing whitespaces the reason why you've decided to add this configuration?
trim_trailing_whitespace = true

@Myllyenko
Copy link
Author

Isn't trailing whitespaces the reason why you've decided to add this configuration? trim_trailing_whitespace = true

Oh, thanks, added it to the config :)

Actually, yes, it was one of the two main reasons (the second one is autoformatting of imports).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (959538e) to head (f4bd9b7).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #340      +/-   ##
============================================
- Coverage     47.34%   47.19%   -0.16%     
  Complexity     1750     1750              
============================================
  Files           309      311       +2     
  Lines         12463    12499      +36     
  Branches       1232     1238       +6     
============================================
- Hits           5901     5899       -2     
- Misses         6102     6140      +38     
  Partials        460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 9a7adfa into ydb-platform:master Oct 29, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants