Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unite trace logs between transport and topics #357

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Jan 13, 2025

No description provided.

@alex268 alex268 requested a review from pnv1 January 13, 2025 16:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 47.43%. Comparing base (f6b9cbf) to head (9c98639).

Files with missing lines Patch % Lines
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 0.00% 34 Missing ⚠️
...ain/java/tech/ydb/topic/write/impl/WriterImpl.java 0.00% 16 Missing ⚠️
...rc/main/java/tech/ydb/topic/impl/GrpcTopicRpc.java 0.00% 6 Missing ⚠️
...a/tech/ydb/core/impl/call/ReadWriteStreamCall.java 0.00% 5 Missing ⚠️
...ain/java/tech/ydb/topic/read/impl/ReadSession.java 0.00% 2 Missing ⚠️
...n/java/tech/ydb/topic/write/impl/WriteSession.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
- Coverage     47.43%   47.43%   -0.01%     
  Complexity     1766     1766              
============================================
  Files           311      311              
  Lines         12543    12548       +5     
  Branches       1244     1245       +1     
============================================
+ Hits           5950     5952       +2     
- Misses         6137     6140       +3     
  Partials        456      456              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit 20c4e6e into ydb-platform:master Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants