Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTL compatibility checker for v2 repository #2

Merged
merged 2 commits into from
Dec 22, 2023
Merged

TTL compatibility checker for v2 repository #2

merged 2 commits into from
Dec 22, 2023

Conversation

Eistern
Copy link
Contributor

@Eistern Eistern commented Dec 22, 2023

No description provided.

@nvamelichev nvamelichev self-requested a review December 22, 2023 12:58
@nvamelichev nvamelichev self-assigned this Dec 22, 2023
nvamelichev
nvamelichev approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@nvamelichev nvamelichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
I'll reapprove the same PR in Right Cloud Java because it'll take a while for us to start deploying YOJ to Maven Central :-)

@nvamelichev
Copy link
Collaborator

Don't worry about the PR check. It has failed because it unsuccessfully tried to publish "successful" status to this PR 🤪

@nvamelichev nvamelichev merged commit f8a9b46 into ydb-platform:main Dec 22, 2023
1 check failed
@Eistern Eistern deleted the feature/ttl-compatibility-checker branch December 22, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvamelichev nvamelichev nvamelichev approved these changes

Assignees

@nvamelichev nvamelichev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eistern @nvamelichev