Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tooltip for earnings [PRO-119] #425

Merged
merged 5 commits into from
Nov 20, 2023
Merged

feat: Tooltip for earnings [PRO-119] #425

merged 5 commits into from
Nov 20, 2023

Conversation

karelianpie
Copy link
Contributor

Description

  • Implement InfoTooltip component
  • Add InfoTooltip to earnings header

Related Issue

https://linear.app/fancy-xopowo/issue/PRO-119/tooltip-for-earnings

Motivation and Context

The earnings heading section can be confusing (where does this come from, why, how, blabla) and adding a little copy to explain where this is coming from in a tooltip can be good.

How Has This Been Tested?

Locally

Screenshots (if appropriate):

v2

web

PRO-119-tooltip-for-earnings-1 PRO-119-tooltip-for-earnings-2

mobile

PRO-119-tooltip-for-earnings-3

v3

web

PRO-119-tooltip-for-earnings-v3-1 PRO-119-tooltip-for-earnings-v3-2

mobile

PRO-119-tooltip-for-earnings-v3-3

@karelianpie karelianpie requested a review from Majorfi November 16, 2023 11:43
@karelianpie karelianpie self-assigned this Nov 16, 2023
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearnfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 1:49pm

@karelianpie karelianpie merged commit f8870fb into feat/v3-main Nov 20, 2023
5 of 6 checks passed
@karelianpie karelianpie deleted the PRO-119 branch November 20, 2023 13:46
Majorfi added a commit that referenced this pull request Nov 30, 2023
* feat: wip v3

* feat: v3 design

* fix: some ui mistakes

* feat: v3 design

* fix: UI

* fix: padding

* fix: wip

* fix: some UI fix

* feat: design

* fix: adapt paddings

* fix: spacing

* fix: design

* fix: search

* fix: some clearning

* fix: remove withdrawal fee

* fix: staking

* wip

* feat: deposit/redeem

* fix: 1

* fix: responsiveness

* fix: animate spin bg

* fix: improve entrance animation

* fix: remove bolt

* fix: only v3

* feat: wip

* fix: toast

* fix: pre-tests

* fix: remove dead code

* fix: registry with kind

* feat: new registry

* feat: icon

* fix: deposit

* feat: add maxLoss popover & hide vaults tab when no subvault

* feat: yieldOnTime

* fix: remove retired/migrated from v3

* fix: deposited amountv3

* fix: linting

* fix: chain

* feat: add link to explorer

* feat: add message

* style: upd header

* copy: change copy of instant yield

* style: update spacing on desktop

* style: change banner warning text color

* copy: change copy for headline

* fix: veYFI refresh and stop-color

* perf: hook optimization and pagination

* fix: pagination

* fix: prefetch & img

* perf: improve global performances

* fix: adjust size

* fix: not use 137

* fix: use filteredChains

* chores: code splitting

* fix: upd hook refres dependencies

* perf: change token icons size for 32px

* fix: imports

* fix: staking data feat

* feat: reenable prefetching

* feat: add yprisma

* fix: remove opt reward file as data automated from yDaemon (#415)

* deps: remove use-query-params, not working properly with framer motion and not required

* fix: change yPrisma asset url

* fix: upd assets

* fix: use base_yearn_assets_uri

* refactor: v3 Vaults About Section (#422)

* feat: Add new vaults about page

* feat: Add about page menu

* chore: yarn.lock

* refactor: Fewer clicks to select a single network (#423)

* refactor: Fewer clicks to select a single network

* Feat/ext 5 (#424)

* nit: change stop-opacity in svg to stopOpacity

* fix: improve query url state + fix no select select all

* lint: fix ts lint

* chores: add pre-commit hook to catch ts errors

* fix: replace undefined with null

---------

Co-authored-by: Majorfi <[email protected]>

---------

Co-authored-by: Major <[email protected]>
Co-authored-by: Majorfi <[email protected]>

* fix: disable eth for non wETH vault & fix zapWith

* feat: Tooltip for earnings [PRO-119] (#425)

* Fix flashing sign (#428)

* fix: flashing of staking contract

* fix: flashing of staking contract

---------

Co-authored-by: Majorfi <[email protected]>

* feat: display staked

* feat: enable polygon fetching for v3 | rename table labels | add deposited & tvl instead of just TVL | filter out polygon for v2

* feat: display NEW when APR type includes new

* fix: link to explorer sometime out

* fix: invalid perf fee on v3

* fix: asset quality by using 128 instead of 32

* chores: update asset URL + sizes

* fix: balance endpoint

* fix: description should use vault description as primary souce

* fix: minor UI update

* fix: size of input

* fix: improve portals error message

* fix: hide low tvl removal

* fix: error message and vault list order

* fix: search

* fix: some mobile issues

* feat: display new when APR is new

* fix: search system

* feat: remove support for Wido solver (#435)

Co-authored-by: Majorfi <[email protected]>

* Feat/upgrade portals to v2 (#441)

* feat: remove support for Wido solver

* feat: upgrade portals solver to V2

---------

Co-authored-by: Majorfi <[email protected]>

* fix: error message missing margin top

* feat: add Changelog commit hook

* chore: bump some packages

* fix: searchbar uncontrolled

* fix: vault list no results

* fix: reset for queryArgs

* chore: set APR as new when it's new

* chore: set polygon only in vault display for V3

* chore: re-add card on the index page

* style: extra padding on top of TVL

* style: update some colors and fix v3 bg

* style: update some colors and fix v3 bg

* chore: move vault-v3 to plain v3. Update popover

* fix: add back icon

* fix: extra zap slippage /100 on portals

* style: update popover header colors

* fix: searchbar display

* feat: enable properly portals for zap with native token

* fix: display outputValue

* fix: pricing system

* fix: avoid scientific notation in OPBoost page

---------

Co-authored-by: Majorfi <[email protected]>
Co-authored-by: Karelian Pie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟢 Done
Development

Successfully merging this pull request may close these issues.

2 participants