Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blank filename lists so that ignore files are respected #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

styrmis
Copy link

@styrmis styrmis commented Nov 19, 2019

Specifying '*' will cause any local ignore files to be skipped.

When all (non-ignored) files should be searched then no files should be specified for the grep program.

When not using a grep program, an error will still be raised if we end up with an empty list of files.

Tested to work with ag and rg.

References #6

Specifying '*' will cause any local ignore files to be skipped. When all
(non-ignored) files should be searched then no files should be specified
for the grep program.
@styrmis
Copy link
Author

styrmis commented Dec 18, 2023

@yegappan Would it be possible to merge this? Happy to alter the implementation if you have feedback on it.

Still using this plugin regularly, now with rg, thank you for publishing it 🙏

@yegappan
Copy link
Owner

yegappan commented Dec 18, 2023

Thanks for the patch. Can you update the help text with a description about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants