Improve JoinedListIterator code coverage #1762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the
JoinedListIterator
class.One of the tests I wanted to add was the following:
Surprisingly, the test failed. Currently, the
previousIndex()
method returns-1
for the first call and0
for the second call, which contradicts the expected behavior. My suspision is that the implementation ofpreviousIndex
is incorrect.The line
previousidx = this.cursor.get() - 1
should likely bepreviousidx = this.cursor.get()
.If my suspicion is confirmed, I will fix the implementation of
previousIndex()
and add the mentioned test to ensure the corrected behavior is validated.