Refactor hangman to harness immutability, object orientation, old&plain cli #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible future improvements. Ascii animation? Improved SecretProviders? Multilanguage support?
Handle state by method parameters (receive previous round as method argument)
Sync changes from original repo
Encapsulate NULL character manipulation inside Guess class. Encapsulate Guess combination strategy inside Guess class. Future work: Completely hide the public final knownText. Implement a better strategy to check if some Guess contains the full secretPhrase already.
…l/hangman.git into feature/object_oriented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you enjoy this refactor as much as I enjoy your articles.
Nice contest. Would love to read your books in the near future.
Regards. https://twitter.com/fejnartal