fix: merge index params when creating index (milvus-io#31127)

issue: milvus-io#31102 --------- Signed-off-by: sunby <[email protected]>
yellow-shine · Mar 11, 2024 · 5c0bb40 · 5c0bb40
1 parent 6a9418d
commit 5c0bb40
Show file tree

Hide file tree

Showing 5 changed files with 303 additions and 290 deletions.
diff --git a/internal/datacoord/index_service.go b/internal/datacoord/index_service.go
@@ -205,6 +205,19 @@ func (s *Server) CreateIndex(ctx context.Context, req *indexpb.CreateIndexReques
 		return merr.Status(err), nil
 	}
 
+	// merge with previous params because create index would not pass mmap params
+	indexes := s.meta.indexMeta.GetFieldIndexes(req.GetCollectionID(), req.GetFieldID(), req.GetIndexName())
+	if len(indexes) == 1 {
+		req.UserIndexParams, err = UpdateParams(indexes[0], indexes[0].UserIndexParams, req.GetUserIndexParams())
+		if err != nil {
+			return merr.Status(err), nil
+		}
+		req.IndexParams, err = UpdateParams(indexes[0], indexes[0].IndexParams, req.GetIndexParams())
+		if err != nil {
+			return merr.Status(err), nil
+		}
+	}
+
 	if indexID == 0 {
 		indexID, err = s.allocator.allocID(ctx)
 		if err != nil {

diff --git a/internal/metastore/mocks/mock_datacoord_catalog.go b/internal/metastore/mocks/mock_datacoord_catalog.go