Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mertify update #67

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Mertify update #67

merged 11 commits into from
Oct 28, 2024

Conversation

yellow-shine
Copy link
Owner

No description provided.

bigsheeper and others added 11 commits October 25, 2024 19:59
Unref the removed L0 segment count.

issue: milvus-io#36918

Signed-off-by: bigsheeper <[email protected]>
Related to milvus-io#37112

Skip load logic used to work only when there is multiple segment load
info entires in load request. In continous delete case, delegator still
loads l0 segment, which occupies lot of memory.

Signed-off-by: Congqi Xia <[email protected]>
…ata (milvus-io#37154)

Segment with numrow 0 don't init bm25 stats, cause flush with bm25 stats
failed.
relate: milvus-io#37150

Signed-off-by: aoiasd <[email protected]>
issue: milvus-io#36621

1. Add API to access task runtime metrics, including:
  - build index task
  - compaction task
  - import task
- balance (including load/release of segments/channels and some leader
tasks on querycoord)
  - sync task
2. Add a debug model to the webpage by using debug=true or debug=false
in the URL query parameters to enable or disable debug mode.

Signed-off-by: jaime <[email protected]>
…vus-io#37127)

Related to milvus-io#35303

Slice of `storage.PrimaryKey` will have extra interface cost for each
element, which may cause notable memory usage when delta row count
number is large.

This PR replaces PrimaryKey slice with PrimaryKeys interface saving the
extra interface cost.

---------

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Yellow Shine <[email protected]>
@yellow-shine yellow-shine merged commit 5b85a19 into master Oct 28, 2024
5 of 6 checks passed
Copy link

mergify bot commented Oct 28, 2024

@yellow-shine Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco label Oct 28, 2024
Copy link

mergify bot commented Oct 28, 2024

@yellow-shine

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants