Test01 #68
Open
Test01 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gment (milvus-io#37168) issue: milvus-io#37147 --------- Signed-off-by: sunby <[email protected]>
…o#37118) Timeout is a bad design for long running tasks, especially using a static timeout config. We should monitor execution progress and fail the task if the progress has been stale for a long time. This pr is a small patch to stop DC from marking compaction tasks timeout, while still waiting for DN to finish. The design is self-conflicted. After this pr, mix and L0 compaction are no longer controlled by DC timeout, but clustering is still under timeout control. The compaction queue capacity grows larger for priority calc, hence timeout compactions appears more often, and when timeout, the queuing tasks will be timeout too, no compaction will success after. See also: milvus-io#37108, milvus-io#37015 --------- Signed-off-by: yangxuan <[email protected]>
issue: milvus-io#33744 Check whether the PK is truly sorted in the debug model. --------- Signed-off-by: Cai Zhang <[email protected]>
issue: milvus-io#36772 Signed-off-by: jaime <[email protected]>
) Related to milvus-io#37177 Previous PR milvus-io#37160 Collection meta is not ref-ed when loading l0 segment in `RemoteLoad` policy, which cause collection meta release when lots of l0 segment released. Signed-off-by: Congqi Xia <[email protected]>
issue: milvus-io#37158 Return the GuaranteeTS so that the subsequent requests following the correct TS. BeginTS is the current timestamp when the task is created. The GuaranteeTS is the one parsed based on both consistency level and beginTS, in PreExecute of the task on Proxy. The delegator will wait until GuaranteeTS is met. In PostExecute of the task on Proxy, the TS of the first iterator request will be returned to the SDK and add it to the subsequent requests. Hence, if the default consistency level is Eventually or Bounded, the order of TS will be > Guarantee TS < BeginTS If it returns the BeginTS, the second request will need to catch up and result in extra 200ms max of latency, which results in something like | Call | Latency | | --- | --- | | first call on `Next()` | 30ms | | second call on `Next()` | 210ms | | third call on `Next()` | 10ms | | fourth call on `Next()` | 11 ms | | ... | ... | where we expect | Call | Latency | | --- | --- | | first call on `Next()` | 30ms | | second call on `Next()` | 10ms | | third call on `Next()` | 10ms | | fourth call on `Next()` | 11 ms | | ... | ... | Signed-off-by: Patrick Weizhi Xu <[email protected]>
Related to milvus-io#37183 Utilize proxy metacache for `HasCollection` request, if collection exists in metacache, it could be deducted that collection must exist in system. Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Yellow Shine <[email protected]>
|
@yellow-shine Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.