-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't persist timeout-based opt-out #41
base: main
Are you sure you want to change the base?
Conversation
@@ -4,7 +4,15 @@ var Insight = require('../../lib'); | |||
var insight = new Insight({ | |||
packageName: 'yeoman', | |||
packageVersion: '0.0.0', | |||
trackingCode: 'GA-1234567-1' | |||
trackingCode: 'GA-1234567-1', | |||
config: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just rely on sinon to mock this object and make assertion against the call. Reading from the stderr/out for assertion purposes is kind of dirty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not bind up this externally-observable change on a minor overhaul of testing patterns. Would you be willing to land the PR as-is and revisit process
mocking at your own convenience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, thing skipped in review would probably never end up being done. This should be fairly easy for you to test here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed merge conflicts (thanks, @sindresorhus), but don't see how to fulfill this request, given that we're dealing with child processes. If you're going to block on it, then I suppose the PR should be closed (unless someone else has an idea).
ping :) |
Fixes gh-39