Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist timeout-based opt-out #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gibson042
Copy link

Fixes gh-39

@@ -4,7 +4,15 @@ var Insight = require('../../lib');
var insight = new Insight({
packageName: 'yeoman',
packageVersion: '0.0.0',
trackingCode: 'GA-1234567-1'
trackingCode: 'GA-1234567-1',
config: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just rely on sinon to mock this object and make assertion against the call. Reading from the stderr/out for assertion purposes is kind of dirty.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not bind up this externally-observable change on a minor overhaul of testing patterns. Would you be willing to land the PR as-is and revisit process mocking at your own convenience?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, thing skipped in review would probably never end up being done. This should be fairly easy for you to test here.

Copy link
Author

@gibson042 gibson042 Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed merge conflicts (thanks, @sindresorhus), but don't see how to fulfill this request, given that we're dealing with child processes. If you're going to block on it, then I suppose the PR should be closed (unless someone else has an idea).

@sindresorhus
Copy link
Member

ping :)

Base automatically changed from master to main January 24, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants