-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add instrumentation hook for wrapping statements #1219
Draft
iand675
wants to merge
14
commits into
yesodweb:master
Choose a base branch
from
iand675:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
reviewed
Mar 31, 2021
@@ -221,6 +224,8 @@ deriving instance (Eq (Key record), Eq record) => Eq (Entity record) | |||
deriving instance (Ord (Key record), Ord record) => Ord (Entity record) | |||
deriving instance (Show (Key record), Show record) => Show (Entity record) | |||
deriving instance (Read (Key record), Read record) => Read (Entity record) | |||
deriving instance (Data (Key record), Data record) => Data (Entity record) | |||
deriving instance (Typeable (Key record), Typeable record) => Typeable (Entity record) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary - Typeable
is automagically derived for all types as of relatively recent GHCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to enable more sophisticated instrumentation of SQL query/execute calls. The way that the statement cache currently works makes it difficult to associate metadata to instrumentation on per-call basis, so this PR adds facilities for that to use with things like OpenTelemetry or Honeycomb:
I wanted to get a little feedback on the particular way that this is implemented to see if there were any better ways to do this, but it seems like a minimally invasive change for the most part.
Before submitting your PR, check that you've:
@since
declarations to the HaddockAfter submitting your PR:
(unreleased)
on the Changelog