Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deserialising Word (and Word8 etc.) from PersistDouble #1491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isomorpheme
Copy link
Contributor

@isomorpheme isomorpheme commented May 3, 2023

This implements approach no. 2 as discussed in #831. Just after authoring this I noticed that there's also PR #1096 which seems to do something more like approach no. 3, and it would conflict with this PR (e.g. it's stricter about deserialising PersistDoubles), though it looks like it's stalled for now.

Closes: #831

Before submitting your PR, check that you've:

  • Added @since declarations to the Haddock I'd like to add these to the relevant instances documenting the change in behaviour, but it looks like Haddock doesn't support adding a comment or the like.
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@isomorpheme isomorpheme marked this pull request as ready for review May 3, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsigned integer support
1 participant