resolved raw string cljs statement-data bug

yetanalytics · Jan 16, 2024 · 7a194ce · 7a194ce
1 parent 4aae5ff
commit 7a194ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/xapi_schema/core.cljc b/src/xapi_schema/core.cljc
@@ -39,7 +39,7 @@
                                       :else sd))
      :cljs (validate-statement-data*
             (cond
-              (string? sd) (.parse js/JSON sd)
+              (string? sd) (js->clj (.parse js/JSON sd))
               :else sd))))
 
 #?(:cljs

diff --git a/test/xapi_schema/core_test.cljc b/test/xapi_schema/core_test.cljc
@@ -8,6 +8,7 @@
                              validate-statements
                              validate-statement-data
                              #?(:cljs validate-statement-data-js)]]
+   [clojure.pprint :refer [pprint]]
    #?(:clj [clojure.data.json :as json]
       :cljs [cljs.core :refer [ExceptionInfo]]))
   #?(:clj (:import [clojure.lang ExceptionInfo])))
@@ -73,7 +74,13 @@
      (testing "with string data"
        (let [statement (json/write-str long-statement)]
          (testing "it parses and returns the validated data"
-           (is (= long-statement (validate-statement-data statement)))))))
+           (is (= long-statement (validate-statement-data statement)))))) 
+     :cljs
+     (testing "with string data"
+       (let [json     (clj->js long-statement)
+             json-str (.stringify js/JSON json)]
+         (testing "it parses and returns the validated data"
+           (is (= long-statement (validate-statement-data json-str))))))) 
 
   #?(:cljs
      (testing "with nested data"