remove getowner from paymentregistry (#152)

* refactor: renaming of yabtransfer to paymentregistry passes all tests, have not yet deployed * fix: add check to see if PaymentRegistry has been correctly deployed * chore: update PaymentRegistry.json * refactor: change 'withdraw' to 'claimPayment' * fix(claim_payment.sh): call clayPayment instead of withdraw * refactor(escrow): rename claimPayment to claim_payment * fix(claim_payment.sh): call correct claimPayment function * remove: getOwner() function from YABTransfer * feat: add getEscrowAddress() + getEscrowClaimPaymentSelector() --------- Co-authored-by: Uriel Mihura <[email protected]> Co-authored-by: JuArce <[email protected]>
yetanotherco · Feb 14, 2024 · 3fe62f8 · 3fe62f8
1 parent 45e2c40
commit 3fe62f8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/contracts/solidity/src/PaymentRegistry.sol b/contracts/solidity/src/PaymentRegistry.sol
@@ -87,6 +87,14 @@ contract PaymentRegistry is Initializable, OwnableUpgradeable, UUPSUpgradeable {
         emit ModifiedEscrowClaimPaymentSelector(snEscrowClaimPaymentSelector);
     }
 
+    function getEscrowAddress() external view returns (uint256) {
+        return _snEscrowAddress;
+    }
+
+    function getEscrowClaimPaymentSelector() external view returns (uint256) {
+        return _snEscrowClaimPaymentSelector;
+    }
+
 
     //// MM ACL:
 
@@ -98,10 +106,6 @@ contract PaymentRegistry is Initializable, OwnableUpgradeable, UUPSUpgradeable {
         _marketMaker = newMMAddress;
     }
 
-    function getOwner() external view returns (address) {
-        return owner();
-    }
-
     modifier onlyOwnerOrMM {
         require(msg.sender == owner() || msg.sender == _marketMaker, "Only Owner or MM can call this function");
         _;

diff --git a/contracts/solidity/test/MM_ACL.sol b/contracts/solidity/test/MM_ACL.sol
@@ -48,7 +48,7 @@ contract TransferTest is Test {
     }
 
     function test_get_owner() public {
-        address ownerAddress = yab_caller.getOwner();
+        address ownerAddress = yab_caller.owner();
         assertEq(ownerAddress, deployer);
     }
 }