-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integration test CICD #137
Merged
JuArce
merged 125 commits into
main
from
106-chore-add-local-networks-for-starknet-and-ethereum
Feb 5, 2024
Merged
test: integration test CICD #137
JuArce
merged 125 commits into
main
from
106-chore-add-local-networks-for-starknet-and-ethereum
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Starknet escrow script + make build, clean & test * add ethereum escrow deploy + documentation * rename commands Makefile * update makefile + readme * fix makefile clean commands * OZ dependency + escrow impl * fix import * forge install: openzeppelin-contracts v5.0.1 * fix feedback comments * fix wrong env name (thx @uri-99) * refactor deploy.sh + add upgrade.sh (wip) * refactor deploy.sh & upgrade.sh * add EscrowV2 for test upgradeable * add upgradeable tests * revert method name changes * fix upgrade.sh + refactor * rename SN_PROXY_ESCROW_ADDRESS to SN_ESCROW_ADDRESS * fix deploy error + change upgrade log * eof * update readme * revert solidity files changes * remove "proxy" from echo * rename starknet rpc env * resolve comments * remove openzeppelin-contracts * rename and move EscrowV2 * fix feedback comments * update README * revert .gitmodules change
* feat: escrow contract without herodotus * fix: change ethereum withrawer in mm_bot * feat: upgreadable Escrow_herodotus contract * refactor: readme with herodotus * refactor: remove comment * refactor: add tmp solution disclaimer on readme * refactor: rename starknet escrow contract * refactor: update wording README.md Co-authored-by: urimihura <[email protected]> * refactor: remove transfer.sh * fix: lowercase escrow module --------- Co-authored-by: urimihura <[email protected]>
…d-ethereum # Conflicts: # .github/workflows/test.yml
… I don't know why
rcatalan98
approved these changes
Feb 5, 2024
JuArce
deleted the
106-chore-add-local-networks-for-starknet-and-ethereum
branch
February 5, 2024 15:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration test is a github action job that make the following steps