Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup default backoff for tranlate method #387

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

STRRL
Copy link
Contributor

@STRRL STRRL commented Feb 28, 2024

sometimes the translating progress would be interrupted by API failure, but after resuming, I get a confusing result about the output #386

This PR append default backoff policy for translation, it would relieve that issue.

@STRRL STRRL force-pushed the default-backoff-on-translate branch from 0ba50a7 to 5cb9e90 Compare February 28, 2024 12:43
@yihong0618
Copy link
Owner

@STRRL
nice, will merge after lint

pip install -U black
black .

Signed-off-by: Zhou Zhiqiang <[email protected]>
@STRRL
Copy link
Contributor Author

STRRL commented Feb 28, 2024

updated! PTAL @yihong0618

mkdocs-material
backoff
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need add this in setup.py

@yihong0618
Copy link
Owner

others LGTM

Signed-off-by: Zhou Zhiqiang <[email protected]>
@STRRL
Copy link
Contributor Author

STRRL commented Feb 29, 2024

Updated! I have no idea about python package management and what setup.py is, if it requires other changes, please let me know!

@yihong0618 yihong0618 merged commit 37808e0 into yihong0618:main Feb 29, 2024
2 checks passed
@yihong0618
Copy link
Owner

Nice thanks will create a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants