feat: support groq translator #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some info to README? @umm233 |
yihong0618
reviewed
May 8, 2024
| @@ -423,7 +433,7 @@ def main(): | |||
| if not options.api_base: | |||
| raise ValueError("`api_base` must be provided when using `deployment_id`") | |||
| e.translate_model.set_deployment_id(options.deployment_id) | |||
| if options.model == "openai": | |||
| if options.model in ("openai", "groq"): | |||
There was a problem hiding this comment.
this seems wrong it always raise error
There was a problem hiding this comment.
Maybe you need run with --model_list arg.
There was a problem hiding this comment.
Because Groq needs to specify the model, I reuse the way of specifying the model.
|
ok, I also want to adjust the format of readme to make it clearer. |
|
copy that merging this first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Groq to translate