Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extensibility issue #278

Closed
wants to merge 3 commits into from
Closed

Fix extensibility issue #278

wants to merge 3 commits into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 15, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #55, #18

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (c802f0a) 87.71%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     87.75%   87.71%   -0.04%     
+ Complexity      598      593       -5     
============================================
  Files             7        7              
  Lines          1331     1327       -4     
============================================
- Hits           1168     1164       -4     
  Misses          163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 15, 2023

PR Summary

  • Refinement of BaseActiveRecordTrait.php

    • This updates the way we access object properties within this PHP file. By refining the method we use to extract data from items in our attributes and related sets, we are aiming to increase the performance of this action while also reducing potential for errors.
  • Enhancements to ActiveRecordTest.php

    • The updates here are primarily to add in additional testing facilities. A new test, testGetExtraAttribute, has been added to ensure the accurate retrieval of a specific attribute (sex) in our Customer database. This will improve the robustness of our product by enabling early detection and resolution of issues.
  • Inclusion of CustomerExtraAttributes.php

    • This new addition is essentially a model of customer's records which includes extra attributes. By incorporating this into our system, we're allowing our application to store and deal with more complex customer data more efficiently.

@Tigrov Tigrov marked this pull request as draft December 15, 2023 06:30
@Tigrov Tigrov closed this May 22, 2024
@Tigrov Tigrov deleted the fix-extensibility-issue branch May 22, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant