Refactor BaseActiveRecord::getDirtyAttributes()

[Tigrov]

• Improve performance
• Allow to use class properties (mixed with $attributes if no class properties) for table row values.

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Fixed issues	-

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5f92e5) 88.02% compared to head (b894025) 87.79%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
- Coverage     88.02%   87.79%   -0.23%     
+ Complexity      587      580       -7     
============================================
  Files             7        7              
  Lines          1319     1311       -8     
============================================
- Hits           1161     1151      -10     
- Misses          158      160       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[what-the-diff]

PR Summary

• Modification to BaseActiveRecord.php

  • Incorporated two additional functions into the file (array_diff_key and array_intersect_key).
  • Updated getDirtyAttributes method to better manage when $names is not defined or null.
  • Updated variables for improved clarity and accuracy within the code.
  • Streamlined the execution of the getDirtyAttributes method.

• Updation to ActiveRecordTest.php

  • For ensuring solid, reliable software, two new testing methods have been added (testGetDirtyAttributesOnNewRecord and testGetDirtyAttributesAfterFind).
  • Enhanced the test coverage of the getDirtyAttributes method to cover multiple use case scenarios.

[xepozz]

Could you bench it?

[xepozz]

What about oldAttributes?

[Tigrov]

Could you bench it?

Before:
benchGetAttributes......................R1 I1 - Mo20.920μs (±1.00%)

After:
benchGetAttributes......................R2 I2 - Mo17.238μs (±1.78%)

[Tigrov]

What about oldAttributes?

getOldAttributes() is a different method, without changes.