Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #387

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Refactoring #387

merged 2 commits into from
Sep 30, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 29, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #367

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (5c4151d) to head (676d223).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ActiveQuery.php 90.90% 3 Missing ⚠️
src/AbstractActiveRecord.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #387      +/-   ##
============================================
+ Coverage     84.99%   85.18%   +0.19%     
+ Complexity      587      583       -4     
============================================
  Files            17       17              
  Lines          1406     1404       -2     
============================================
+ Hits           1195     1196       +1     
+ Misses          211      208       -3     
Flag Coverage Δ
85.18% <93.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 3dde794 into master Sep 30, 2024
30 checks passed
@Tigrov Tigrov deleted the refactoring branch September 30, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants