Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTE query expressions #278

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Fix CTE query expressions #278

merged 3 commits into from
Oct 14, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 28, 2023

RECURSIVE expression is not needed In MSSQL CTE

Related with yiisoft/db#761

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • New Method: buildWithQueries
    A fresh method 'buildWithQueries' has been developed in 'DQLQueryBuilder.php'. This method obtains an array of parameters and updates them. Specifically, it ensures a setting named 'recursive' is set to false. This helps in controlling how deep we dive into our data relations when fetching information, improving efficiency. The updated parameters are then utilized in the subsequent processes. This simplifies the data gathering process and enhances customizability when working with data relationships.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2538828) 97.76% compared to head (db7860e) 97.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
+ Coverage     97.76%   97.78%   +0.01%     
- Complexity      221      223       +2     
============================================
  Files            15       15              
  Lines           627      631       +4     
============================================
+ Hits            613      617       +4     
  Misses           14       14              
Files Coverage Δ
src/DQLQueryBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 28, 2023 11:14
@Tigrov Tigrov added the type:bug Bug label Sep 29, 2023
@Tigrov Tigrov merged commit bd3e290 into yiisoft:master Oct 14, 2023
16 of 17 checks passed
@Tigrov Tigrov deleted the fix-cte branch October 14, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants