Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTE query expressions #240

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Fix CTE query expressions #240

merged 3 commits into from
Oct 14, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 28, 2023

RECURSIVE expression is not needed In Oracle CTE

Related with yiisoft/db#761

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • Introduction of a New Method in the DQLQueryBuilder Class
    A new method named buildWithQueries has been added to the DQLQueryBuilder class. This method stands as a bridge to accept and process two types of arrays - withs and params. The key enhancement here is that it sets a specific value (recursive value to false) in all elements of the withs array before proceeding with any further operations. It completes its operation by calling its parent method buildWithQueries with the processed arrays (withs and params). The result of this parent method is subsequently returned as the output. This new method's existence streamlines and manages specific operations within the DQLQueryBuilder class, leading to more efficient system performance.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8a066f3) 98.29% compared to head (bc0acf9) 98.30%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
+ Coverage     98.29%   98.30%   +0.01%     
- Complexity      187      189       +2     
============================================
  Files            16       16              
  Lines           585      589       +4     
============================================
+ Hits            575      579       +4     
  Misses           10       10              
Files Coverage Δ
src/DQLQueryBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 28, 2023 11:15
@Tigrov Tigrov added the type:bug Bug label Sep 29, 2023
@Tigrov Tigrov merged commit 245d3ee into yiisoft:master Oct 14, 2023
16 of 17 checks passed
@Tigrov Tigrov deleted the fix-cte branch October 14, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants